id
int64
599M
3.48B
number
int64
1
7.8k
title
stringlengths
1
290
state
stringclasses
2 values
comments
listlengths
0
30
created_at
timestamp[s]date
2020-04-14 10:18:02
2025-10-05 06:37:50
updated_at
timestamp[s]date
2020-04-27 16:04:17
2025-10-05 10:32:43
closed_at
timestamp[s]date
2020-04-14 12:01:40
2025-10-01 13:56:03
body
stringlengths
0
228k
user
stringlengths
3
26
html_url
stringlengths
46
51
pull_request
dict
is_pull_request
bool
2 classes
863,191,655
2,245
Add `key` type and duplicates verification with hashing
closed
[]
2021-04-20T20:03:19
2021-05-10T18:04:37
2021-05-10T17:31:22
Closes #2230 There is currently no verification for the data type and the uniqueness of the keys yielded by the `dataset_builder`. This PR is currently a work in progress with the following goals: - [x] Adding `hash_salt` to `ArrowWriter` so that the keys belonging to different splits have different hash - [x] Add `key` arrtibute to `ArrowWriter.write()` for hashing - [x] Add a hashing class which takes an input key of certain type (`str`/`int`/anything convertible to string) and produces a 128-bit hash using `hashlib.md5` - [x] Creating a function giving a custom error message when non-unique keys are found **[This will take care of type-checking for keys]** - [x] Checking for duplicate keys in `writer.write()` for each batch [**NOTE**: This PR is currently concerned with `GeneratorBasedBuilder` only, for simplification. A subsequent PR will be made in future for `ArrowBasedBuilder`] @lhoestq Thank you for the feedback. It would be great to have your guidance on this!
NikhilBartwal
https://github.com/huggingface/datasets/pull/2245
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2245", "html_url": "https://github.com/huggingface/datasets/pull/2245", "diff_url": "https://github.com/huggingface/datasets/pull/2245.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2245.patch", "merged_at": "2021-05-10T17:31:21" }
true
863,029,946
2,244
Set specific cache directories per test function call
open
[]
2021-04-20T17:06:22
2022-07-06T15:19:48
null
Implement specific cache directories (datasets, metrics and modules) per test function call. Currently, the cache directories are set within the temporary test directory, but they are shared across all test function calls. This PR implements specific cache directories for each test function call, so that tests are atomic and there are no side effects.
albertvillanova
https://github.com/huggingface/datasets/pull/2244
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2244", "html_url": "https://github.com/huggingface/datasets/pull/2244", "diff_url": "https://github.com/huggingface/datasets/pull/2244.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2244.patch", "merged_at": null }
true
862,909,389
2,243
Map is slow and processes batches one after another
closed
[]
2021-04-20T14:58:20
2021-05-03T17:54:33
2021-05-03T17:54:32
## Describe the bug I have a somewhat unclear bug to me, where I can't figure out what the problem is. The code works as expected on a small subset of my dataset (2000 samples) on my local machine, but when I execute the same code with a larger dataset (1.4 million samples) this problem occurs. Thats why I can't give exact steps to reproduce, I'm sorry. I process a large dataset in a two step process. I first call map on a dataset I load from disk and create a new dataset from it. This works like expected and `map` uses all workers I started it with. Then I process the dataset created by the first step, again with `map`, which is really slow and starting only one or two process at a time. Number of processes is the same for both steps. pseudo code: ```python ds = datasets.load_from_disk("path") new_dataset = ds.map(work, batched=True, ...) # fast uses all processes final_dataset = new_dataset.map(work2, batched=True, ...) # slow starts one process after another ``` ## Expected results Second stage should be as fast as the first stage. ## Versions Paste the output of the following code: - Datasets: 1.5.0 - Python: 3.8.8 (default, Feb 24 2021, 21:46:12) - Platform: Linux-5.4.0-60-generic-x86_64-with-glibc2.10 Do you guys have any idea? Thanks a lot!
villmow
https://github.com/huggingface/datasets/issues/2243
null
false
862,870,205
2,242
Link to datasets viwer on Quick Tour page returns "502 Bad Gateway"
closed
[]
2021-04-20T14:19:51
2021-04-20T15:02:45
2021-04-20T15:02:45
Link to datasets viwer (https://huggingface.co/datasets/viewer/) on Quick Tour page (https://huggingface.co/docs/datasets/quicktour.html) returns "502 Bad Gateway" The same error with https://huggingface.co/datasets/viewer/?dataset=glue&config=mrpc
martavillegas
https://github.com/huggingface/datasets/issues/2242
null
false
862,696,460
2,241
Add SLR32 to OpenSLR
closed
[]
2021-04-20T11:02:45
2021-04-23T16:21:24
2021-04-23T15:36:15
I would like to add SLR32 to OpenSLR. It contains four South African languages: Afrikaans, Sesotho, Setswana and isiXhosa
cahya-wirawan
https://github.com/huggingface/datasets/pull/2241
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2241", "html_url": "https://github.com/huggingface/datasets/pull/2241", "diff_url": "https://github.com/huggingface/datasets/pull/2241.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2241.patch", "merged_at": "2021-04-23T15:36:15" }
true
862,537,856
2,240
Clarify how to load wikihow
closed
[]
2021-04-20T08:02:58
2021-04-21T09:54:57
2021-04-21T09:54:57
Explain clearer how to load the dataset in the manual download instructions. En relation with #2239.
albertvillanova
https://github.com/huggingface/datasets/pull/2240
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2240", "html_url": "https://github.com/huggingface/datasets/pull/2240", "diff_url": "https://github.com/huggingface/datasets/pull/2240.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2240.patch", "merged_at": "2021-04-21T09:54:57" }
true
861,904,306
2,239
Error loading wikihow dataset
closed
[]
2021-04-19T21:02:31
2021-04-20T16:33:11
2021-04-20T16:33:11
## Describe the bug When attempting to load wikihow into a dataset with ```python from datasets import load_dataset dataset = load_dataset('wikihow', data_dir='./wikihow') ``` I get the message: ``` AttributeError: 'BuilderConfig' object has no attribute 'filename' ``` at the end of a [full stack trace](https://gist.github.com/odellus/602c3b2de52f541d353b1022f320ffc2). ## Steps to reproduce the bug I have followed the instructions for creating a wikihow dataset. The [wikihow dataset site](https://huggingface.co/datasets/wikihow) says to use ```python from datasets import load_dataset dataset = load_dataset('wikihow') ``` to load the dataset. I do so and I get the message ``` AssertionError: The dataset wikihow with config all requires manual data. Please follow the manual download instructions: You need to manually download two wikihow files. An overview of which files to download can be seen at https://github.com/mahnazkoupaee/WikiHow-Dataset. You need to download the following two files manually: 1) https://ucsb.app.box.com/s/ap23l8gafpezf4tq3wapr6u8241zz358 and save the file under <path/to/folder>/wikihowAll.csv 2) https://ucsb.app.box.com/s/7yq601ijl1lzvlfu4rjdbbxforzd2oag and save the file under <path/to/folder>/wikihowSep.csv The <path/to/folder> can e.g. be "~/manual_wikihow_data". Wikihow can then be loaded using the following command `datasets.load_dataset("wikihow", data_dir="<path/to/folder>")`. . Manual data can be loaded with `datasets.load_dataset(wikihow, data_dir='<path/to/manual/data>') ``` So I create a directory `./wikihow` and download `wikihowAll.csv` and `wikihowSep.csv` into the new directory. Then I run ```python from datasets import load_dataset dataset = load_dataset('wikihow', data_dir='./wikihow') ``` that's when I get the [stack trace](https://gist.github.com/odellus/602c3b2de52f541d353b1022f320ffc2) ## Expected results I expected it to load the downloaded files into a dataset. ## Actual results ```python Using custom data configuration default-data_dir=.%2Fwikihow Downloading and preparing dataset wikihow/default (download: Unknown size, generated: Unknown size, post-processed: Unknown size, total: Unknown size) to /home/azureuser/.cache/huggingface/datasets/wikihow/default-data_dir=.%2Fwikihow/0.0.0/58f42f8f0e4d459811a0f69aaab35870093830ccd58006769e7e1eb3e0e686c2... --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) <ipython-input-9-5e4d40142f30> in <module> ----> 1 dataset = load_dataset('wikihow',data_dir='./wikihow') ~/.local/lib/python3.6/site-packages/datasets/load.py in load_dataset(path, name, data_dir, data_files, split, cache_dir, features, download_config, download_mode, ignore_verifications, keep_in_memory, save_infos, script_version, use_auth_token, **config_kwargs) 745 try_from_hf_gcs=try_from_hf_gcs, 746 base_path=base_path,--> 747 use_auth_token=use_auth_token, 748 ) 749 ~/.local/lib/python3.6/site-packages/datasets/builder.py in download_and_prepare(self, download_config, download_mode, ignore_verifications, try_from_hf_gcs, dl_manager, base_path, use_auth_token, **download_and_prepare_kwargs) 577 if not downloaded_from_gcs: 578 self._download_and_prepare( --> 579 dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs 580 ) 581 # Sync info ~/.local/lib/python3.6/site-packages/datasets/builder.py in _download_and_prepare(self, dl_manager, verify_infos, **prepare_split_kwargs) 632 split_dict = SplitDict(dataset_name=self.name) 633 split_generators_kwargs = self._make_split_generators_kwargs(prepare_split_kwargs) --> 634 split_generators = self._split_generators(dl_manager, **split_generators_kwargs) 635 636 # Checksums verification ~/.cache/huggingface/modules/datasets_modules/datasets/wikihow/58f42f8f0e4d459811a0f69aaab35870093830ccd58006769e7e1eb3e0e686c2/wikihow.py in _split_generators(self, dl_manager) 132 133 path_to_manual_file = os.path.join( --> 134 os.path.abspath(os.path.expanduser(dl_manager.manual_dir)), self.config.filename 135 ) 136 AttributeError: 'BuilderConfig' object has no attribute 'filename' ``` ## Versions Paste the output of the following code: ```python import datasets import sys import platform print(f""" - Datasets: {datasets.__version__} - Python: {sys.version} - Platform: {platform.platform()} """) ``` ``` - Datasets: 1.5.0 - Python: 3.6.9 (default, Jan 26 2021, 15:33:00) [GCC 8.4.0] - Platform: Linux-5.4.0-1046-azure-x86_64-with-Ubuntu-18.04-bionic ```
odellus
https://github.com/huggingface/datasets/issues/2239
null
false
861,518,291
2,238
NLU evaluation data
closed
[]
2021-04-19T16:47:20
2021-04-23T15:32:05
2021-04-23T15:32:05
New intent classification dataset from https://github.com/xliuhw/NLU-Evaluation-Data
dkajtoch
https://github.com/huggingface/datasets/pull/2238
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2238", "html_url": "https://github.com/huggingface/datasets/pull/2238", "diff_url": "https://github.com/huggingface/datasets/pull/2238.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2238.patch", "merged_at": "2021-04-23T15:32:05" }
true
861,427,439
2,237
Update Dataset.dataset_size after transformed with map
open
[]
2021-04-19T15:19:38
2021-04-20T14:22:05
null
After loading a dataset, if we transform it by using `.map` its `dataset_size` attirbute is not updated.
albertvillanova
https://github.com/huggingface/datasets/issues/2237
null
false
861,388,145
2,236
Request to add StrategyQA dataset
open
[]
2021-04-19T14:46:26
2021-04-19T14:46:26
null
## Request to add StrategyQA dataset - **Name:** StrategyQA - **Description:** open-domain QA [(project page)](https://allenai.org/data/strategyqa) - **Paper:** [url](https://arxiv.org/pdf/2101.02235.pdf) - **Data:** [here](https://allenai.org/data/strategyqa) - **Motivation:** uniquely-formulated dataset that also includes a question-decomposition breakdown and associated Wikipedia annotations for each step. Good for multi-hop reasoning modeling.
sarahwie
https://github.com/huggingface/datasets/issues/2236
null
false
861,040,716
2,235
Update README.md
closed
[]
2021-04-19T08:21:02
2021-04-19T12:49:19
2021-04-19T12:49:19
Adding relevant citations (paper accepted at AAAI 2020 & EMNLP 2020) to the benchmark
PierreColombo
https://github.com/huggingface/datasets/pull/2235
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2235", "html_url": "https://github.com/huggingface/datasets/pull/2235", "diff_url": "https://github.com/huggingface/datasets/pull/2235.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2235.patch", "merged_at": "2021-04-19T12:49:19" }
true
860,442,246
2,234
Fix bash snippet formatting in ADD_NEW_DATASET.md
closed
[]
2021-04-17T16:01:08
2021-04-19T10:57:31
2021-04-19T07:51:36
This PR indents the paragraphs around the bash snippets in ADD_NEW_DATASET.md to fix formatting.
mariosasko
https://github.com/huggingface/datasets/pull/2234
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2234", "html_url": "https://github.com/huggingface/datasets/pull/2234", "diff_url": "https://github.com/huggingface/datasets/pull/2234.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2234.patch", "merged_at": "2021-04-19T07:51:36" }
true
860,097,084
2,233
Fix `xnli` dataset tuple key
closed
[]
2021-04-16T19:12:42
2021-04-19T08:56:42
2021-04-19T08:56:42
Closes #2229 The `xnli` dataset yields a tuple key in case of `ar` which is inconsistant with the acceptable key types (str/int). The key was thus ported to `str` keeping the original information intact.
NikhilBartwal
https://github.com/huggingface/datasets/pull/2233
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2233", "html_url": "https://github.com/huggingface/datasets/pull/2233", "diff_url": "https://github.com/huggingface/datasets/pull/2233.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2233.patch", "merged_at": "2021-04-19T08:56:42" }
true
860,075,931
2,232
Start filling GLUE dataset card
closed
[]
2021-04-16T18:37:37
2021-04-21T09:33:09
2021-04-21T09:33:08
The dataset card was pretty much empty. I added the descriptions (mainly from TFDS since the script is the same), and I also added the tasks tags as well as examples for a subset of the tasks. cc @sgugger
lhoestq
https://github.com/huggingface/datasets/pull/2232
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2232", "html_url": "https://github.com/huggingface/datasets/pull/2232", "diff_url": "https://github.com/huggingface/datasets/pull/2232.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2232.patch", "merged_at": "2021-04-21T09:33:08" }
true
859,850,488
2,231
Fix map when removing columns on a formatted dataset
closed
[]
2021-04-16T14:08:55
2021-04-16T15:10:05
2021-04-16T15:10:04
This should fix issue #2226 The `remove_columns` argument was ignored on formatted datasets
lhoestq
https://github.com/huggingface/datasets/pull/2231
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2231", "html_url": "https://github.com/huggingface/datasets/pull/2231", "diff_url": "https://github.com/huggingface/datasets/pull/2231.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2231.patch", "merged_at": "2021-04-16T15:10:04" }
true
859,817,159
2,230
Keys yielded while generating dataset are not being checked
closed
[]
2021-04-16T13:29:47
2021-05-10T17:31:21
2021-05-10T17:31:21
The keys used in the dataset generation script to ensure the same order is generated on every user's end should be checked for their types (i.e either `str` or `int`) as well as whether they are unique or not. Currently, the keys are not being checked for any of these, as evident from `xnli' dataset generation: https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/datasets/xnli/xnli.py#L196 Even after having a tuple as key, the dataset is generated without any warning. Also, as tested in the case of `anli` dataset (I tweeked the dataset script to use `1` as a key for every example): ``` >>> import datasets >>> nik = datasets.load_dataset('anli') Downloading and preparing dataset anli/plain_text (download: 17.76 MiB, generated: 73.55 MiB, post-processed: Unknown size, total: 91.31 MiB) to C:\Users\nikhil\.cache\huggingface\datasets\anli\plain_text\0.1.0\43fa2c99c10bf8478f1fa0860f7b122c6b277c4c41306255b7641257cf4e3299... 0 examples [00:00, ? examples/s]1 {'uid': '0fd0abfb-659e-4453-b196-c3a64d2d8267', 'premise': 'The Parma trolleybus system (Italian: "Rete filoviaria di Parma" ) forms part of the public transport network of the city and "comune" of Parma, in the region of Emilia-Romagna, northern Italy. In operation since 1953, the system presently comprises four urban routes.', 'hypothesis': 'The trolleybus system has over 2 urban routes', 'label': 'entailment', 'reason': ''} 2021-04-16 12:38:14.483968: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll 1 examples [00:01, 1.87s/ examples]1 {'uid': '7ed72ff4-40b7-4f8a-b1b9-6c612aa62c84', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': "Sharron Macready was a popular character through the 1980's.", 'label': 'neutral', 'reason': ''} 1 {'uid': '5d2930a3-62ac-485d-94d7-4e36cbbcd7b5', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': "Bastedo didn't keep any pets because of her views on animal rights.", 'label': 'neutral', 'reason': ''} 1 {'uid': '324db753-ddc9-4a85-a825-f09e2e5aebdd', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': 'Alexandra Bastedo was named by her mother.', 'label': 'neutral', 'reason': ''} 1 {'uid': '4874f429-da0e-406a-90c7-22240ff3ddf8', 'premise': 'Alexandra Lendon Bastedo (9 March 1946 – 12 January 2014) was a British actress, best known for her role as secret agent Sharron Macready in the 1968 British espionage/science fiction adventure series "The Champions". She has been cited as a sex symbol of the 1960s and 1970s. Bastedo was a vegetarian and animal welfare advocate.', 'hypothesis': 'Bastedo cared for all the animals that inhabit the earth.', 'label': 'neutral', 'reason': ''} ``` Here also, the dataset was generated successfuly even hough it had same keys without any warning. The reason appears to stem from here: https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/src/datasets/builder.py#L988 Here, although it has access to every key, but it is not being checked and the example is written directly: https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/src/datasets/builder.py#L992 I would like to take this issue if you allow me. Thank You!
NikhilBartwal
https://github.com/huggingface/datasets/issues/2230
null
false
859,810,602
2,229
`xnli` dataset creating a tuple key while yielding instead of `str` or `int`
closed
[]
2021-04-16T13:21:53
2021-04-19T08:56:42
2021-04-19T08:56:42
When using `ds = datasets.load_dataset('xnli', 'ar')`, the dataset generation script uses the following section of code in the egging, which yields a tuple key instead of the specified `str` or `int` key: https://github.com/huggingface/datasets/blob/56346791aed417306d054d89bd693d6b7eab17f7/datasets/xnli/xnli.py#L196 Since, community datasets in Tensorflow Datasets also use HF datasets, this causes a Tuple key error while loading HF's `xnli` dataset. I'm up for sending a fix for this, I think we can simply use `file_idx + "_" + row_idx` as a unique key instead of a tuple.
NikhilBartwal
https://github.com/huggingface/datasets/issues/2229
null
false
859,795,563
2,228
[WIP] Add ArrayXD support for fixed size list.
open
[]
2021-04-16T13:04:08
2022-07-06T15:19:48
null
Add support for fixed size list for ArrayXD when shape is known . See https://github.com/huggingface/datasets/issues/2146 Since offset are not stored anymore, the file size is now roughly equal to the actual data size.
jblemoine
https://github.com/huggingface/datasets/pull/2228
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2228", "html_url": "https://github.com/huggingface/datasets/pull/2228", "diff_url": "https://github.com/huggingface/datasets/pull/2228.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2228.patch", "merged_at": null }
true
859,771,526
2,227
Use update_metadata_with_features decorator in class_encode_column method
closed
[]
2021-04-16T12:31:41
2021-04-16T13:49:40
2021-04-16T13:49:39
Following @mariosasko 's comment
SBrandeis
https://github.com/huggingface/datasets/pull/2227
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2227", "html_url": "https://github.com/huggingface/datasets/pull/2227", "diff_url": "https://github.com/huggingface/datasets/pull/2227.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2227.patch", "merged_at": "2021-04-16T13:49:39" }
true
859,720,302
2,226
Batched map fails when removing all columns
closed
[]
2021-04-16T11:17:01
2022-10-05T17:32:15
2022-10-05T17:32:15
Hi @lhoestq , I'm hijacking this issue, because I'm currently trying to do the approach you recommend: > Currently the optimal setup for single-column computations is probably to do something like > > ```python > result = dataset.map(f, input_columns="my_col", remove_columns=dataset.column_names) > ``` Here is my code: (see edit, in which I added a simplified version ``` This is the error: ```bash pyarrow.lib.ArrowInvalid: Column 1 named tokens expected length 8964 but got length 1000 ``` I wonder why this error occurs, when I delete every column? Can you give me a hint? ### Edit: I preprocessed my dataset before (using map with the features argument) and saved it to disk. May this be part of the error? I can iterate over the complete dataset and print every sample before calling map. There seems to be no other problem with the dataset. I tried to simplify the code that crashes: ```python # works log.debug(dataset.column_names) log.debug(dataset) for i, sample in enumerate(dataset): log.debug(i, sample) # crashes counted_dataset = dataset.map( lambda x: {"a": list(range(20))}, input_columns=column, remove_columns=dataset.column_names, load_from_cache_file=False, num_proc=num_workers, batched=True, ) ``` ``` pyarrow.lib.ArrowInvalid: Column 1 named tokens expected length 20 but got length 1000 ``` Edit2: May this be a problem with a schema I set when preprocessing the dataset before? I tried to add the `features` argument to the function and then I get a new error: ```python # crashes counted_dataset = dataset.map( lambda x: {"a": list(range(20))}, input_columns=column, remove_columns=dataset.column_names, load_from_cache_file=False, num_proc=num_workers, batched=True, features=datasets.Features( { "a": datasets.Sequence(datasets.Value("int32")) } ) ) ``` ``` File "env/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 1704, in _map_single writer.write_batch(batch) File "env/lib/python3.8/site-packages/datasets/arrow_writer.py", line 312, in write_batch col_type = schema.field(col).type if schema is not None else None File "pyarrow/types.pxi", line 1341, in pyarrow.lib.Schema.field KeyError: 'Column tokens does not exist in schema' ``` _Originally posted by @villmow in https://github.com/huggingface/datasets/issues/2193#issuecomment-820230874_
villmow
https://github.com/huggingface/datasets/issues/2226
null
false
858,469,561
2,225
fixed one instance of 'train' to 'test'
closed
[]
2021-04-15T04:26:40
2021-04-15T22:09:50
2021-04-15T21:19:09
I believe this should be 'test' instead of 'train'
alexwdong
https://github.com/huggingface/datasets/pull/2225
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2225", "html_url": "https://github.com/huggingface/datasets/pull/2225", "diff_url": "https://github.com/huggingface/datasets/pull/2225.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2225.patch", "merged_at": "2021-04-15T21:19:09" }
true
857,983,361
2,224
Raise error if Windows max path length is not disabled
open
[]
2021-04-14T14:57:20
2021-04-14T14:59:13
null
On startup, raise an error if Windows max path length is not disabled; ask the user to disable it. Linked to discussion in #2220.
albertvillanova
https://github.com/huggingface/datasets/issues/2224
null
false
857,870,800
2,223
Set test cache config
closed
[]
2021-04-14T12:55:24
2021-04-15T19:11:25
2021-04-15T19:11:25
Currently, running the tests populates the default cache directory `"~/.cache"`. This PR monkey-patches the config to set the cache directory within the temporary test directory, avoiding side effects.
albertvillanova
https://github.com/huggingface/datasets/pull/2223
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2223", "html_url": "https://github.com/huggingface/datasets/pull/2223", "diff_url": "https://github.com/huggingface/datasets/pull/2223.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2223.patch", "merged_at": "2021-04-15T19:11:25" }
true
857,847,231
2,222
Fix too long WindowsFileLock name
closed
[]
2021-04-14T12:26:52
2021-04-14T15:00:25
2021-04-14T14:46:19
Fix WindowsFileLock name longer than allowed MAX_PATH by shortening the basename.
albertvillanova
https://github.com/huggingface/datasets/pull/2222
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2222", "html_url": "https://github.com/huggingface/datasets/pull/2222", "diff_url": "https://github.com/huggingface/datasets/pull/2222.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2222.patch", "merged_at": null }
true
857,833,770
2,221
Add SLR70 - SLR80 and SLR86 to OpenSLR dataset
closed
[]
2021-04-14T12:09:18
2021-04-14T13:50:19
2021-04-14T13:50:19
I would like to add SLR70, SLR71, SLR72, SLR73, SLR74, SLR75, SLR76, SLR77, SLR78, SLR79, SLR80 and SLR86 to OpenSLR dataset. The languages are: Nigerian English, Chilean Spanish, Columbian Spanish, Peruvian Spanish, Puerto Rico Spanish, Venezuelan Spanish, Basque, Galician, Gujarati and Kannada.
cahya-wirawan
https://github.com/huggingface/datasets/pull/2221
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2221", "html_url": "https://github.com/huggingface/datasets/pull/2221", "diff_url": "https://github.com/huggingface/datasets/pull/2221.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2221.patch", "merged_at": "2021-04-14T13:50:19" }
true
857,774,626
2,220
Fix infinite loop in WindowsFileLock
closed
[]
2021-04-14T10:49:58
2021-04-14T14:59:50
2021-04-14T14:59:34
Raise exception to avoid infinite loop.
albertvillanova
https://github.com/huggingface/datasets/pull/2220
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2220", "html_url": "https://github.com/huggingface/datasets/pull/2220", "diff_url": "https://github.com/huggingface/datasets/pull/2220.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2220.patch", "merged_at": null }
true
857,321,242
2,219
Added CUAD dataset
closed
[]
2021-04-13T21:05:03
2021-04-24T14:25:51
2021-04-16T08:50:44
Dataset link : https://github.com/TheAtticusProject/cuad/ Working on README.md currently. Closes #2084 and [#1](https://github.com/TheAtticusProject/cuad/issues/1).
bhavitvyamalik
https://github.com/huggingface/datasets/pull/2219
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2219", "html_url": "https://github.com/huggingface/datasets/pull/2219", "diff_url": "https://github.com/huggingface/datasets/pull/2219.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2219.patch", "merged_at": "2021-04-16T08:50:44" }
true
857,238,435
2,218
Duplicates in the LAMA dataset
open
[]
2021-04-13T18:59:49
2021-04-14T21:42:27
null
I observed duplicates in the LAMA probing dataset, see a minimal code below. ``` >>> import datasets >>> dataset = datasets.load_dataset('lama') No config specified, defaulting to: lama/trex Reusing dataset lama (/home/anam/.cache/huggingface/datasets/lama/trex/1.1.0/97deffae13eca0a18e77dfb3960bb31741e973586f5c1fe1ec0d6b5eece7bddc) >>> train_dataset = dataset['train'] >>> train_dataset[0] {'description': 'language or languages a person has learned from early childhood', 'label': 'native language', 'masked_sentence': 'Louis Jules Trochu ([lwi ʒyl tʁɔʃy]; 12 March 1815 – 7 October 1896) was a [MASK] military leader and politician.', 'obj_label': 'French', 'obj_surface': 'French', 'obj_uri': 'Q150', 'predicate_id': 'P103', 'sub_label': 'Louis Jules Trochu', 'sub_surface': 'Louis Jules Trochu', 'sub_uri': 'Q441235', 'template': 'The native language of [X] is [Y] .', 'template_negated': '[X] is not owned by [Y] .', 'type': 'N-1', 'uuid': '40b2ed1c-0961-482e-844e-32596b6117c8'} >>> train_dataset[1] {'description': 'language or languages a person has learned from early childhood', 'label': 'native language', 'masked_sentence': 'Louis Jules Trochu ([lwi ʒyl tʁɔʃy]; 12 March 1815 – 7 October 1896) was a [MASK] military leader and politician.', 'obj_label': 'French', 'obj_surface': 'French', 'obj_uri': 'Q150', 'predicate_id': 'P103', 'sub_label': 'Louis Jules Trochu', 'sub_surface': 'Louis Jules Trochu', 'sub_uri': 'Q441235', 'template': 'The native language of [X] is [Y] .', 'template_negated': '[X] is not owned by [Y] .', 'type': 'N-1', 'uuid': '40b2ed1c-0961-482e-844e-32596b6117c8'} ``` I checked the original data available at https://dl.fbaipublicfiles.com/LAMA/data.zip. This particular duplicated comes from: ``` {"uuid": "40b2ed1c-0961-482e-844e-32596b6117c8", "obj_uri": "Q150", "obj_label": "French", "sub_uri": "Q441235", "sub_label": "Louis Jules Trochu", "predicate_id": "P103", "evidences": [{"sub_surface": "Louis Jules Trochu", "obj_surface": "French", "masked_sentence": "Louis Jules Trochu ([lwi \u0292yl t\u0281\u0254\u0283y]; 12 March 1815 \u2013 7 October 1896) was a [MASK] military leader and politician."}, {"sub_surface": "Louis Jules Trochu", "obj_surface": "French", "masked_sentence": "Louis Jules Trochu ([lwi \u0292yl t\u0281\u0254\u0283y]; 12 March 1815 \u2013 7 October 1896) was a [MASK] military leader and politician."}]} ``` What is the best way to deal with these duplicates if I want to use `datasets` to probe with LAMA?
amarasovic
https://github.com/huggingface/datasets/issues/2218
null
false
857,011,314
2,217
Revert breaking change in cache_files property
closed
[]
2021-04-13T14:20:04
2021-04-14T14:24:24
2021-04-14T14:24:23
#2025 changed the format of `Dataset.cache_files`. Before it was formatted like ```python [{"filename": "path/to/file.arrow", "start": 0, "end": 1337}] ``` and it was changed to ```python ["path/to/file.arrow"] ``` since there's no start/end offsets available anymore. To make this less breaking, I'm setting the format back to a list of dicts: ```python [{"filename": "path/to/file.arrow"}] ```
lhoestq
https://github.com/huggingface/datasets/pull/2217
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2217", "html_url": "https://github.com/huggingface/datasets/pull/2217", "diff_url": "https://github.com/huggingface/datasets/pull/2217.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2217.patch", "merged_at": "2021-04-14T14:24:23" }
true
856,955,534
2,216
added real label for glue/mrpc to test set
closed
[]
2021-04-13T13:20:20
2021-04-13T13:53:20
2021-04-13T13:53:19
Added real label to `glue.py` `mrpc` task for test split.
philschmid
https://github.com/huggingface/datasets/pull/2216
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2216", "html_url": "https://github.com/huggingface/datasets/pull/2216", "diff_url": "https://github.com/huggingface/datasets/pull/2216.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2216.patch", "merged_at": "2021-04-13T13:53:19" }
true
856,716,791
2,215
Add datasets SLR35 and SLR36 to OpenSLR
closed
[]
2021-04-13T08:24:07
2021-04-13T14:05:14
2021-04-13T14:05:14
I would like to add [SLR35](https://openslr.org/35/) (18GB) and [SLR36](https://openslr.org/36/) (22GB) which are Large Javanese and Sundanese ASR training data set collected by Google in collaboration with Reykjavik University and Universitas Gadjah Mada in Indonesia.
cahya-wirawan
https://github.com/huggingface/datasets/pull/2215
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2215", "html_url": "https://github.com/huggingface/datasets/pull/2215", "diff_url": "https://github.com/huggingface/datasets/pull/2215.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2215.patch", "merged_at": "2021-04-13T14:05:14" }
true
856,333,657
2,214
load_metric error: module 'datasets.utils.file_utils' has no attribute 'add_start_docstrings'
closed
[]
2021-04-12T20:26:01
2021-04-23T15:20:02
2021-04-23T15:20:02
I'm having the same problem as [Notebooks issue 10](https://github.com/huggingface/notebooks/issues/10) on datasets 1.2.1, and it seems to be an issue with the datasets package. ```python >>> from datasets import load_metric >>> metric = load_metric("glue", "sst2") Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/ext3/miniconda3/lib/python3.8/site-packages/datasets-1.2.1-py3.8.egg/datasets/load.py", line 502, in load_metric File "/ext3/miniconda3/lib/python3.8/site-packages/datasets-1.2.1-py3.8.egg/datasets/load.py", line 66, in import_main_class File "/ext3/miniconda3/lib/python3.8/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1014, in _gcd_import File "<frozen importlib._bootstrap>", line 991, in _find_and_load File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 671, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 783, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/home/ns4008/.cache/huggingface/modules/datasets_modules/metrics/glue/e4606ab9804a36bcd5a9cebb2cb65bb14b6ac78ee9e6d5981fa679a495dd55de/glue.py", line 105, in <module> @datasets.utils.file_utils.add_start_docstrings(_DESCRIPTION, _KWARGS_DESCRIPTION) AttributeError: module 'datasets.utils.file_utils' has no attribute 'add_start_docstrings' ```
nsaphra
https://github.com/huggingface/datasets/issues/2214
null
false
856,025,320
2,213
Fix lc_quad download checksum
closed
[]
2021-04-12T14:16:59
2021-04-14T22:04:54
2021-04-14T13:42:25
Fixes #2211
mariosasko
https://github.com/huggingface/datasets/pull/2213
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2213", "html_url": "https://github.com/huggingface/datasets/pull/2213", "diff_url": "https://github.com/huggingface/datasets/pull/2213.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2213.patch", "merged_at": "2021-04-14T13:42:25" }
true
855,999,133
2,212
Can't reach "https://storage.googleapis.com/illuin/fquad/train.json.zip" when trying to load fquad dataset
closed
[]
2021-04-12T13:49:56
2023-10-03T16:09:19
2023-10-03T16:09:18
I'm trying to load the [fquad dataset](https://huggingface.co/datasets/fquad) by running: ```Python fquad = load_dataset("fquad") ``` which produces the following error: ``` Using custom data configuration default Downloading and preparing dataset fquad/default (download: 3.14 MiB, generated: 6.62 MiB, post-processed: Unknown size, total: 9.76 MiB) to /root/.cache/huggingface/datasets/fquad/default/0.1.0/778dc2c85813d05ddd0c17087294d5f8f24820752340958070876b677af9f061... --------------------------------------------------------------------------- ConnectionError Traceback (most recent call last) <ipython-input-48-a2721797e23b> in <module>() ----> 1 fquad = load_dataset("fquad") 11 frames /usr/local/lib/python3.7/dist-packages/datasets/utils/file_utils.py in get_from_cache(url, cache_dir, force_download, proxies, etag_timeout, resume_download, user_agent, local_files_only, use_etag, max_retries, use_auth_token) 614 raise FileNotFoundError("Couldn't find file at {}".format(url)) 615 _raise_if_offline_mode_is_enabled(f"Tried to reach {url}") --> 616 raise ConnectionError("Couldn't reach {}".format(url)) 617 618 # Try a second time ConnectionError: Couldn't reach https://storage.googleapis.com/illuin/fquad/train.json.zip ``` Does anyone know why that is and how to fix it?
hanss0n
https://github.com/huggingface/datasets/issues/2212
null
false
855,988,410
2,211
Getting checksum error when trying to load lc_quad dataset
closed
[]
2021-04-12T13:38:58
2021-04-14T13:42:25
2021-04-14T13:42:25
I'm having issues loading the [lc_quad](https://huggingface.co/datasets/fquad) dataset by running: ```Python lc_quad = load_dataset("lc_quad") ``` which is giving me the following error: ``` Using custom data configuration default Downloading and preparing dataset lc_quad/default (download: 3.69 MiB, generated: 19.77 MiB, post-processed: Unknown size, total: 23.46 MiB) to /root/.cache/huggingface/datasets/lc_quad/default/2.0.0/5a98fe174603f5dec6df07edf1c2b4d2317210d2ad61f5a393839bca4d64e5a7... --------------------------------------------------------------------------- NonMatchingChecksumError Traceback (most recent call last) <ipython-input-42-404ace83f73c> in <module>() ----> 1 lc_quad = load_dataset("lc_quad") 3 frames /usr/local/lib/python3.7/dist-packages/datasets/utils/info_utils.py in verify_checksums(expected_checksums, recorded_checksums, verification_name) 37 if len(bad_urls) > 0: 38 error_msg = "Checksums didn't match" + for_verification_name + ":\n" ---> 39 raise NonMatchingChecksumError(error_msg + str(bad_urls)) 40 logger.info("All the checksums matched successfully" + for_verification_name) 41 NonMatchingChecksumError: Checksums didn't match for dataset source files: ['https://github.com/AskNowQA/LC-QuAD2.0/archive/master.zip'] ``` Does anyone know why this could be and how I fix it?
hanss0n
https://github.com/huggingface/datasets/issues/2211
null
false
855,709,400
2,210
dataloading slow when using HUGE dataset
closed
[]
2021-04-12T08:33:02
2021-04-13T02:03:05
2021-04-13T02:03:05
Hi, When I use datasets with 600GB data, the dataloading speed increases significantly. I am experimenting with two datasets, and one is about 60GB and the other 600GB. Simply speaking, my code uses `datasets.set_format("torch")` function and let pytorch-lightning handle ddp training. When looking at the pytorch-lightning supported profile of two different runs, I see that fetching a batch(`get_train_batch`) consumes an unreasonable amount of time when data is large. What could be the cause? * 60GB data ``` Action | Mean duration (s) |Num calls | Total time (s) | Percentage % | ------------------------------------------------------------------------------------------------------------------------------------ Total | - |_ | 200.33 | 100 % | ------------------------------------------------------------------------------------------------------------------------------------ run_training_epoch | 71.994 |1 | 71.994 | 35.937 | run_training_batch | 0.64373 |100 | 64.373 | 32.133 | optimizer_step_and_closure_0 | 0.64322 |100 | 64.322 | 32.108 | training_step_and_backward | 0.61004 |100 | 61.004 | 30.452 | model_backward | 0.37552 |100 | 37.552 | 18.745 | model_forward | 0.22813 |100 | 22.813 | 11.387 | training_step | 0.22759 |100 | 22.759 | 11.361 | get_train_batch | 0.066385 |100 | 6.6385 | 3.3138 | ``` * 600GB data ``` Action | Mean duration (s) |Num calls | Total time (s) | Percentage % | ------------------------------------------------------------------------------------------------------------------------------------ Total | - |_ | 3285.6 | 100 % | ------------------------------------------------------------------------------------------------------------------------------------ run_training_epoch | 1397.9 |1 | 1397.9 | 42.546 | run_training_batch | 7.2596 |100 | 725.96 | 22.095 | optimizer_step_and_closure_0 | 7.2589 |100 | 725.89 | 22.093 | training_step_and_backward | 7.223 |100 | 722.3 | 21.984 | model_backward | 6.9662 |100 | 696.62 | 21.202 | get_train_batch | 6.322 |100 | 632.2 | 19.241 | model_forward | 0.24902 |100 | 24.902 | 0.75789 | training_step | 0.2485 |100 | 24.85 | 0.75633 | ```
hwijeen
https://github.com/huggingface/datasets/issues/2210
null
false
855,638,232
2,209
Add code of conduct to the project
closed
[]
2021-04-12T07:16:14
2021-04-12T17:55:52
2021-04-12T17:55:52
Add code of conduct to the project and link it from README and CONTRIBUTING. This was already done in `transformers`.
albertvillanova
https://github.com/huggingface/datasets/pull/2209
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2209", "html_url": "https://github.com/huggingface/datasets/pull/2209", "diff_url": "https://github.com/huggingface/datasets/pull/2209.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2209.patch", "merged_at": "2021-04-12T17:55:52" }
true
855,343,835
2,208
Remove Python2 leftovers
closed
[]
2021-04-11T16:08:03
2021-04-14T22:05:36
2021-04-14T13:40:51
This PR removes Python2 leftovers since this project aims for Python3.6+ (and as of 2020 Python2 is no longer officially supported)
mariosasko
https://github.com/huggingface/datasets/pull/2208
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2208", "html_url": "https://github.com/huggingface/datasets/pull/2208", "diff_url": "https://github.com/huggingface/datasets/pull/2208.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2208.patch", "merged_at": "2021-04-14T13:40:50" }
true
855,267,383
2,207
making labels consistent across the datasets
closed
[]
2021-04-11T10:03:56
2022-06-01T16:23:08
2022-06-01T16:21:10
Hi For accessing the labels one can type ``` >>> a.features['label'] ClassLabel(num_classes=3, names=['entailment', 'neutral', 'contradiction'], names_file=None, id=None) ``` The labels however are not consistent with the actual labels sometimes, for instance in case of XNLI, the actual labels are 0,1,2, but if one try to access as above they are entailment, neutral,contradiction, it would be great to have the labels consistent. thanks
dorost1234
https://github.com/huggingface/datasets/issues/2207
null
false
855,252,415
2,206
Got pyarrow error when loading a dataset while adding special tokens into the tokenizer
closed
[]
2021-04-11T08:40:09
2021-11-10T12:18:30
2021-11-10T12:04:28
I added five more special tokens into the GPT2 tokenizer. But after that, when I try to pre-process the data using my previous code, I got an error shown below: Traceback (most recent call last): File "/home/xuyan/anaconda3/envs/convqa/lib/python3.7/site-packages/datasets/arrow_dataset.py", line 1687, in _map_single writer.write(example) File "/home/xuyan/anaconda3/envs/convqa/lib/python3.7/site-packages/datasets/arrow_writer.py", line 296, in write self.write_on_file() File "/home/xuyan/anaconda3/envs/convqa/lib/python3.7/site-packages/datasets/arrow_writer.py", line 270, in write_on_file pa_array = pa.array(typed_sequence) File "pyarrow/array.pxi", line 222, in pyarrow.lib.array File "pyarrow/array.pxi", line 110, in pyarrow.lib._handle_arrow_array_protocol File "/home/xuyan/anaconda3/envs/convqa/lib/python3.7/site-packages/datasets/arrow_writer.py", line 108, in __arrow_array__ out = out.cast(pa.list_(self.optimized_int_type)) File "pyarrow/array.pxi", line 810, in pyarrow.lib.Array.cast File "/home/xuyan/anaconda3/envs/convqa/lib/python3.7/site-packages/pyarrow/compute.py", line 281, in cast return call_function("cast", [arr], options) File "pyarrow/_compute.pyx", line 465, in pyarrow._compute.call_function File "pyarrow/_compute.pyx", line 294, in pyarrow._compute.Function.call File "pyarrow/error.pxi", line 122, in pyarrow.lib.pyarrow_internal_check_status File "pyarrow/error.pxi", line 84, in pyarrow.lib.check_status pyarrow.lib.ArrowInvalid: Integer value 50259 not in range: -128 to 127 Do you have any idea about it?
yana-xuyan
https://github.com/huggingface/datasets/issues/2206
null
false
855,207,605
2,205
Updating citation information on LinCE readme
closed
[]
2021-04-11T03:18:05
2021-04-12T17:53:34
2021-04-12T17:53:34
Hi! I just updated the citation information in this PR. It had an additional bibtex from one of the datasets used in LinCE and then the LinCE bibtex. I removed the former and added a link that shows the full list of citations for each dataset. Thanks!
gaguilar
https://github.com/huggingface/datasets/pull/2205
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2205", "html_url": "https://github.com/huggingface/datasets/pull/2205", "diff_url": "https://github.com/huggingface/datasets/pull/2205.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2205.patch", "merged_at": "2021-04-12T17:53:34" }
true
855,144,431
2,204
Add configurable options to `seqeval` metric
closed
[]
2021-04-10T19:58:19
2021-04-15T13:49:46
2021-04-15T13:49:46
Fixes #2148 Adds options to use strict mode, different schemes of evaluation, sample weight and adjust zero_division behavior, if encountered. `seqeval` provides schemes as objects, hence dynamic import from string, to avoid making the user do the import (thanks to @albertvillanova for the `importlib` idea).
marrodion
https://github.com/huggingface/datasets/pull/2204
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2204", "html_url": "https://github.com/huggingface/datasets/pull/2204", "diff_url": "https://github.com/huggingface/datasets/pull/2204.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2204.patch", "merged_at": "2021-04-15T13:49:46" }
true
855,053,595
2,203
updated banking77 train and test data
closed
[]
2021-04-10T12:10:10
2021-04-23T14:33:39
2021-04-23T14:33:39
hsali
https://github.com/huggingface/datasets/pull/2203
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2203", "html_url": "https://github.com/huggingface/datasets/pull/2203", "diff_url": "https://github.com/huggingface/datasets/pull/2203.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2203.patch", "merged_at": null }
true
854,501,109
2,202
Add classes GenerateMode, DownloadConfig and Version to the documentation
closed
[]
2021-04-09T12:58:19
2021-04-12T17:58:00
2021-04-12T17:57:59
Add documentation for classes `GenerateMode`, `DownloadConfig` and `Version`. Update the docstring of `load_dataset` to create cross-reference links to the classes. Related to #2187.
albertvillanova
https://github.com/huggingface/datasets/pull/2202
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2202", "html_url": "https://github.com/huggingface/datasets/pull/2202", "diff_url": "https://github.com/huggingface/datasets/pull/2202.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2202.patch", "merged_at": "2021-04-12T17:57:59" }
true
854,499,563
2,201
Fix ArrowWriter overwriting features in ArrowBasedBuilder
closed
[]
2021-04-09T12:56:19
2021-04-12T13:32:17
2021-04-12T13:32:16
This should fix the issues with CSV loading experienced in #2153 and #2200. The CSV builder is an ArrowBasedBuilder that had an issue with its ArrowWriter used to write the arrow file from the csv data. The writer wasn't initialized with the features passed by the user. Therefore the writer was inferring the features from the arrow data, discarding the features passed by the user. I fixed that and I updated the tests
lhoestq
https://github.com/huggingface/datasets/pull/2201
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2201", "html_url": "https://github.com/huggingface/datasets/pull/2201", "diff_url": "https://github.com/huggingface/datasets/pull/2201.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2201.patch", "merged_at": "2021-04-12T13:32:16" }
true
854,449,656
2,200
_prepare_split will overwrite DatasetBuilder.info.features
closed
[]
2021-04-09T11:47:13
2021-06-04T10:37:35
2021-06-04T10:37:35
Hi, here is my issue: I initialized a Csv datasetbuilder with specific features: ``` def get_dataset_features(data_args): features = {} if data_args.text_features: features.update({text_feature: hf_features.Value("string") for text_feature in data_args.text_features.strip().split(",")}) if data_args.num_features: features.update({text_feature: hf_features.Value("float32") for text_feature in data_args.num_features.strip().split(",")}) if data_args.label_classes: features["label"] = hf_features.ClassLabel(names=data_args.label_classes.strip().split(",")) else: features["label"] = hf_features.Value("float32") return hf_features.Features(features) datasets = load_dataset(extension, data_files=data_files, sep=data_args.delimiter, header=data_args.header, column_names=data_args.column_names.split(",") if data_args.column_names else None, features=get_dataset_features(data_args=data_args)) ``` The `features` is printout as below before `builder_instance.as_dataset` is called: ``` {'label': ClassLabel(num_classes=2, names=['unacceptable', 'acceptable'], names_file=None, id=None), 'notated': Value(dtype='string', id=None), 'sentence': Value(dtype='string', id=None), 'src_code': Value(dtype='string', id=None)} ```` But after the `builder_instance.as_dataset` is called for Csv dataset builder, the `features` is changed to: ``` {'label': Value(dtype='int64', id=None), 'notated': Value(dtype='string', id=None), 'sentence': Value(dtype='string', id=None), 'src_code': Value(dtype='string', id=None)} ``` After digged into the code, I releazed that in `ArrowBasedBuilder._prepare_split`, the DatasetBuilder's info's features will be overwrited by `ArrowWriter`'s `_features`. But `ArrowWriter` is initailized without passing `features`. So my concern is: It's this overwrite must be done, or, should it be an option to pass features in `_prepare_split` function?
Gforky
https://github.com/huggingface/datasets/issues/2200
null
false
854,417,318
2,199
Fix backward compatibility in Dataset.load_from_disk
closed
[]
2021-04-09T11:01:10
2021-04-09T15:57:05
2021-04-09T15:57:05
Fix backward compatibility when loading from disk an old dataset saved to disk with indices using key "_indices_data_files". Related to #2195.
albertvillanova
https://github.com/huggingface/datasets/pull/2199
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2199", "html_url": "https://github.com/huggingface/datasets/pull/2199", "diff_url": "https://github.com/huggingface/datasets/pull/2199.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2199.patch", "merged_at": "2021-04-09T15:57:05" }
true
854,357,481
2,198
added file_permission in load_dataset
closed
[]
2021-04-09T09:39:06
2021-04-16T14:11:46
2021-04-16T14:11:46
As discussed in #2065 I've added `file_permission` argument in `load_dataset`. Added mainly 2 things here: 1) Permission of downloaded datasets when converted to .arrow files can be changed with argument `file_permission` argument in `load_dataset` (default is 0o644 only) 2) Incase the user uses `map` later on to generate another cache file of dataset, it ensures the permissions of newly generated file are similar to that of` *-train.arrow` file inside cache_dir for that dataset.
bhavitvyamalik
https://github.com/huggingface/datasets/pull/2198
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2198", "html_url": "https://github.com/huggingface/datasets/pull/2198", "diff_url": "https://github.com/huggingface/datasets/pull/2198.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2198.patch", "merged_at": null }
true
854,356,559
2,197
fix missing indices_files in load_form_disk
closed
[]
2021-04-09T09:37:57
2021-04-09T09:54:40
2021-04-09T09:54:39
This should fix #2195 `load_from_disk` was failing if there was no "_indices_files" field in state.json. This can happen if the dataset has no indices mapping
lhoestq
https://github.com/huggingface/datasets/pull/2197
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2197", "html_url": "https://github.com/huggingface/datasets/pull/2197", "diff_url": "https://github.com/huggingface/datasets/pull/2197.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2197.patch", "merged_at": "2021-04-09T09:54:39" }
true
854,126,114
2,196
`load_dataset` caches two arrow files?
closed
[]
2021-04-09T03:49:19
2021-04-12T05:25:29
2021-04-12T05:25:29
Hi, I am using datasets to load large json file of 587G. I checked the cached folder and found that there are two arrow files created: * `cache-ed205e500a7dc44c.arrow` - 355G * `json-train.arrow` - 582G Why is the first file created? If I delete it, would I still be able to `load_from_disk`?
hwijeen
https://github.com/huggingface/datasets/issues/2196
null
false
854,070,194
2,195
KeyError: '_indices_files' in `arrow_dataset.py`
closed
[]
2021-04-09T01:37:12
2021-04-09T09:55:09
2021-04-09T09:54:39
After pulling the latest master, I'm getting a crash when `load_from_disk` tries to load my local dataset. Trace: ``` Traceback (most recent call last): File "load_data.py", line 11, in <module> dataset = load_from_disk(SRC) File "/opt/conda/envs/py38/lib/python3.8/site-packages/datasets/load.py", line 784, in load_from_disk return DatasetDict.load_from_disk(dataset_path, fs, keep_in_memory=keep_in_memory) File "/opt/conda/envs/py38/lib/python3.8/site-packages/datasets/dataset_dict.py", line 692, in load_from_disk dataset_dict[k] = Dataset.load_from_disk(dataset_dict_split_path, fs, keep_in_memory=keep_in_memory) File "/opt/conda/envs/py38/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 634, in load_from_disk if state["_indices_files"]: KeyError: '_indices_files' ``` I believe this is the line causing the error since there may not be a `_indices_files` key in the older versions: https://github.com/huggingface/datasets/blob/b70141e3c5149430951773aaa0155555c5fb3e76/src/datasets/arrow_dataset.py#L634 May I suggest using `state.get()` instead of directly indexing the dictionary? @lhoestq
samsontmr
https://github.com/huggingface/datasets/issues/2195
null
false
853,909,452
2,194
py3.7: TypeError: can't pickle _LazyModule objects
closed
[]
2021-04-08T21:02:48
2021-04-09T16:56:50
2021-04-09T01:52:57
While this works fine with py3.8, under py3.7, with a totally new conda env and transformers install: ``` git clone https://github.com/huggingface/transformers cd transformers pip install -e .[testing] export BS=1; rm -rf /tmp/test-clm; PYTHONPATH=src USE_TF=0 CUDA_VISIBLE_DEVICES=0 python \ examples/language-modeling/run_clm.py --model_name_or_path distilgpt2 --dataset_name wikitext \ --dataset_config_name wikitext-2-raw-v1 --do_train --max_train_samples 1 \ --per_device_train_batch_size $BS --output_dir /tmp/test-clm --block_size 128 --logging_steps 1 \ --fp16 ``` ``` Traceback (most recent call last): File "examples/language-modeling/run_clm.py", line 453, in <module> main() File "examples/language-modeling/run_clm.py", line 336, in main load_from_cache_file=not data_args.overwrite_cache, File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/dataset_dict.py", line 303, in map for k, dataset in self.items() File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/dataset_dict.py", line 303, in <dictcomp> for k, dataset in self.items() File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/arrow_dataset.py", line 1259, in map update_data=update_data, File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/arrow_dataset.py", line 157, in wrapper out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs) File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/fingerprint.py", line 158, in wrapper self._fingerprint, transform, kwargs_for_fingerprint File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/fingerprint.py", line 105, in update_fingerprint hasher.update(transform_args[key]) File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/fingerprint.py", line 57, in update self.m.update(self.hash(value).encode("utf-8")) File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/fingerprint.py", line 53, in hash return cls.hash_default(value) File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/fingerprint.py", line 46, in hash_default return cls.hash_bytes(dumps(value)) File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/utils/py_utils.py", line 389, in dumps dump(obj, file) File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/utils/py_utils.py", line 361, in dump Pickler(file, recurse=True).dump(obj) File "/home/stas/anaconda3/lib/python3.7/site-packages/dill/_dill.py", line 454, in dump StockPickler.dump(self, obj) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 437, in dump self.save(obj) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 504, in save f(self, obj) # Call unbound method with explicit self File "/home/stas/anaconda3/lib/python3.7/site-packages/datasets/utils/py_utils.py", line 556, in save_function obj=obj, File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 638, in save_reduce save(args) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 504, in save f(self, obj) # Call unbound method with explicit self File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 789, in save_tuple save(element) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 504, in save f(self, obj) # Call unbound method with explicit self File "/home/stas/anaconda3/lib/python3.7/site-packages/dill/_dill.py", line 941, in save_module_dict StockPickler.save_dict(pickler, obj) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 859, in save_dict self._batch_setitems(obj.items()) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 885, in _batch_setitems save(v) File "/home/stas/anaconda3/lib/python3.7/pickle.py", line 524, in save rv = reduce(self.proto) TypeError: can't pickle _LazyModule objects ``` ``` $ python --version Python 3.7.4 $ python -m torch.utils.collect_env Collecting environment information... PyTorch version: 1.8.0.dev20210110+cu110 Is debug build: False CUDA used to build PyTorch: 11.0 ROCM used to build PyTorch: N/A OS: Ubuntu 20.04.2 LTS (x86_64) GCC version: (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 Clang version: 10.0.0-4ubuntu1 CMake version: version 3.16.3 ``` Thanks.
stas00
https://github.com/huggingface/datasets/issues/2194
null
false
853,725,707
2,193
Filtering/mapping on one column is very slow
closed
[]
2021-04-08T18:16:14
2021-04-26T16:13:59
2021-04-26T16:13:59
I'm currently using the `wikipedia` dataset— I'm tokenizing the articles with the `tokenizers` library using `map()` and also adding a new `num_tokens` column to the dataset as part of that map operation. I want to be able to _filter_ the dataset based on this `num_tokens` column, but even when I specify `input_columns=['num_tokens']`, it seems that the entirety of each row is loaded into memory, which makes the operation take much longer than it should. Indeed, `filter` currently just calls `map`, and I found that in `_map_single` on lines 1690-1704 of `arrow_dataset.py`, the method is just grabbing slices of _all the rows_ of the dataset and then passing only the specified columns to the map function. It seems that, when the user passes a value for `input_columns`, the `map` function should create a temporary pyarrow table by selecting just those columns, and then get slices from that table. Or something like that— I'm not very familiar with the pyarrow API. I know that in the meantime I can sort of get around this by simply only returning the rows that match my filter criterion from the tokenizing function I pass to `map()`, but I actually _also_ want to map on just the `num_tokens` column in order to compute batches with a roughly uniform number of tokens per batch. I would also ideally like to be able to change my minimum and maximum article lengths without having to re-tokenize the entire dataset. PS: This is definitely not a "dataset request." I'm realizing that I don't actually know how to remove labels from my own issues on other people's repos, if that is even possible.
norabelrose
https://github.com/huggingface/datasets/issues/2193
null
false
853,547,910
2,192
Fix typo in huggingface hub
closed
[]
2021-04-08T14:42:24
2021-04-08T15:47:41
2021-04-08T15:47:40
pip knows how to resolve to `huggingface_hub`, but conda doesn't! The `packaging` dependency is also required for the build to complete.
LysandreJik
https://github.com/huggingface/datasets/pull/2192
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2192", "html_url": "https://github.com/huggingface/datasets/pull/2192", "diff_url": "https://github.com/huggingface/datasets/pull/2192.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2192.patch", "merged_at": "2021-04-08T15:47:40" }
true
853,364,204
2,191
Refactorize tests to use Dataset as context manager
closed
[]
2021-04-08T11:21:04
2021-04-19T07:53:11
2021-04-19T07:53:10
Refactorize Dataset tests to use Dataset as context manager.
albertvillanova
https://github.com/huggingface/datasets/pull/2191
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2191", "html_url": "https://github.com/huggingface/datasets/pull/2191", "diff_url": "https://github.com/huggingface/datasets/pull/2191.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2191.patch", "merged_at": "2021-04-19T07:53:10" }
true
853,181,564
2,190
News_commentary Dataset Translation Pairs are of Incorrect Language Specified Pairs
closed
[]
2021-04-08T07:53:43
2021-05-24T10:03:55
2021-05-24T10:03:55
I used load_dataset to load the news_commentary dataset for "ar-en" translation pairs but found translations from Arabic to Hindi. ``` train_ds = load_dataset("news_commentary", "ar-en", split='train[:98%]') val_ds = load_dataset("news_commentary", "ar-en", split='train[98%:]') # filtering out examples that are not ar-en translations but ar-hi val_ds = val_ds.filter(lambda example, indice: indice not in chain(range(1312,1327) ,range(1384,1399), range(1030,1042)), with_indices=True) ``` * I'm fairly new to using datasets so I might be doing something wrong
anassalamah
https://github.com/huggingface/datasets/issues/2190
null
false
853,052,891
2,189
save_to_disk doesn't work when we use concatenate_datasets function before creating the final dataset_object.
closed
[]
2021-04-08T04:42:53
2022-06-01T16:32:15
2022-06-01T16:32:15
As you can see, it saves the entire dataset. @lhoestq You can check by going through the following example, ``` from datasets import load_from_disk,concatenate_datasets loaded_data=load_from_disk('/home/gsir059/HNSW-ori/my_knowledge_dataset') n=20 kb_list=[loaded_data.shard(n, i, contiguous=True) for i in range(n)] final_dataset=concatenate_datasets([kb_list[1],kb_list[2]]) final_dataset.save_to_disk('/home/gsir059/haha/k.arrow') ```
shamanez
https://github.com/huggingface/datasets/issues/2189
null
false
853,044,166
2,188
Duplicate data in Timit dataset
closed
[]
2021-04-08T04:21:54
2021-04-08T12:13:19
2021-04-08T12:13:19
I ran a simple code to list all texts in Timit dataset and the texts were all the same. Is this dataset corrupted? **Code:** timit = load_dataset("timit_asr") print(*timit['train']['text'], sep='\n') **Result:** Would such an act of refusal be useful? Would such an act of refusal be useful? Would such an act of refusal be useful? Would such an act of refusal be useful? ... ... Would such an act of refusal be useful?
thanh-p
https://github.com/huggingface/datasets/issues/2188
null
false
852,939,736
2,187
Question (potential issue?) related to datasets caching
open
[]
2021-04-08T00:16:28
2023-01-03T18:30:38
null
I thought I had disabled datasets caching in my code, as follows: ``` from datasets import set_caching_enabled ... def main(): # disable caching in datasets set_caching_enabled(False) ``` However, in my log files I see messages like the following: ``` 04/07/2021 18:34:42 - WARNING - datasets.builder - Using custom data configuration default-888a87931cbc5877 04/07/2021 18:34:42 - WARNING - datasets.builder - Reusing dataset csv (xxxx/cache-transformers/datasets/csv/default-888a87931cbc5877/0.0.0/965b6429be0fc05f975b608ce64e1fa941cc8fb4f30629b523d2390f3c0e1a93 ``` Can you please let me know what this reusing dataset csv means? I wouldn't expect any reusing with the datasets caching disabled. Thank you!
ioana-blue
https://github.com/huggingface/datasets/issues/2187
null
false
852,840,819
2,186
GEM: new challenge sets
closed
[]
2021-04-07T21:39:07
2021-04-07T21:56:35
2021-04-07T21:56:35
This PR updates the GEM dataset to: - remove extraneous fields in WikiAuto after https://github.com/huggingface/datasets/pull/2171 fixed the source - add context and services to Schema Guided Dialog - Add new or update challenge sets for MLSUM ES and DE, XSUM, and SGD
yjernite
https://github.com/huggingface/datasets/pull/2186
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2186", "html_url": "https://github.com/huggingface/datasets/pull/2186", "diff_url": "https://github.com/huggingface/datasets/pull/2186.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2186.patch", "merged_at": "2021-04-07T21:56:35" }
true
852,684,395
2,185
.map() and distributed training
closed
[]
2021-04-07T18:22:14
2021-10-23T07:11:15
2021-04-09T15:38:31
Hi, I have a question regarding distributed training and the `.map` call on a dataset. I have a local dataset "my_custom_dataset" that I am loading with `datasets = load_from_disk(dataset_path=my_path)`. `dataset` is then tokenized: ```python datasets = load_from_disk(dataset_path=my_path) [...] def tokenize_function(examples): return tokenizer(examples[text_column_name]) logger.info("Mapping dataset to tokenized dataset.") tokenized_datasets = datasets.map( tokenize_function, batched=True, num_proc=preprocessing_num_workers, remove_columns=column_names, load_from_cache_file=True, ) ``` I am using 31 workers (`preprocessing_num_workers=31`) and thus it creates 31 `cache*.arrow` files in `my_path/train` (there is only a train split). When I relaunch the script, the map is tokenization is skipped in favor of loading the 31 previously cached files, and that's perfect. Everything so far was done by launching a **single process script**. I now launch the same training script in **distributed mode** (`pytorch -m torch.distributed.launch --nproc_per_node 2`). However, once it reaches the map call, it re-does the tokenization... instead of loading the 31 cached files. I tried adding the `cache_file_name` argument: `cache_file_name={"train": my_path/one_of_the_arrow_file}`, but I can't give the 31 cached files, so it probably isn't the right way to do it. **My question: what is the best way to load cached files if they were pre-processed and dumped in multiple arrow files?** It seems automatically handled for single processes but fails on distributed training. - I am following the same structure as the examples of transformers (more specifically [run_clm.py](https://github.com/huggingface/transformers/blob/master/examples/language-modeling/run_clm.py) in my case) - I am using 1.5.0 version of datasets if that matters.
VictorSanh
https://github.com/huggingface/datasets/issues/2185
null
false
852,597,258
2,184
Implementation of class_encode_column
closed
[]
2021-04-07T16:47:43
2021-04-16T11:44:37
2021-04-16T11:26:59
Addresses #2176 I'm happy to discuss the API and internals!
SBrandeis
https://github.com/huggingface/datasets/pull/2184
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2184", "html_url": "https://github.com/huggingface/datasets/pull/2184", "diff_url": "https://github.com/huggingface/datasets/pull/2184.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2184.patch", "merged_at": "2021-04-16T11:26:59" }
true
852,518,411
2,183
Fix s3fs tests for py36 and py37+
closed
[]
2021-04-07T15:17:11
2021-04-08T08:54:45
2021-04-08T08:54:44
Recently several changes happened: 1. latest versions of `fsspec` require python>3.7 for async features 2. `s3fs` added a dependency on `aiobotocore`, which is not compatible with the `moto` s3 mock context manager This PR fixes both issues, by pinning `fsspec` and `s3fs` for python 3.6, and by using `moto` in server mode to support running the tests on python>=3.7 with the latest version of `fsspec` and `s3fs`. cc @philschmid
lhoestq
https://github.com/huggingface/datasets/pull/2183
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2183", "html_url": "https://github.com/huggingface/datasets/pull/2183", "diff_url": "https://github.com/huggingface/datasets/pull/2183.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2183.patch", "merged_at": "2021-04-08T08:54:44" }
true
852,384,872
2,182
Set default in-memory value depending on the dataset size
closed
[]
2021-04-07T13:00:18
2021-04-20T14:20:12
2021-04-20T10:04:04
Set a default value for `in_memory` depending on the size of the dataset to be loaded. Close #2179. TODO: - [x] Add a section in the docs about this. - ~Add a warning if someone tries to specify `cache_file_name=` in `map`, `filter` etc. on a dataset that is in memory, since the computation is not going to be cached in this case.~
albertvillanova
https://github.com/huggingface/datasets/pull/2182
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2182", "html_url": "https://github.com/huggingface/datasets/pull/2182", "diff_url": "https://github.com/huggingface/datasets/pull/2182.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2182.patch", "merged_at": "2021-04-20T10:04:03" }
true
852,261,607
2,181
Error when loading a HUGE json file (pyarrow.lib.ArrowInvalid: straddling object straddles two block boundaries)
closed
[]
2021-04-07T10:26:46
2021-04-12T07:15:55
2021-04-12T07:15:55
Hi, thanks for the great library. I have used the brilliant library for a couple of small projects, and now using it for a fairly big project. When loading a huge json file of 500GB, pyarrow complains as follows: ``` Traceback (most recent call last): File "/home/user/.pyenv/versions/3.7.9/lib/python3.7/site-packages/datasets/builder.py", line 531, in incomplete_dir yield tmp_dir File "/home/user/.pyenv/versions/3.7.9/lib/python3.7/site-packages/datasets/builder.py", line 573, in download_and_prepare dl_manager=dl_manager, verify_infos=verify_infos, **download_and_prepare_kwargs File "/home/user/.pyenv/versions/3.7.9/lib/python3.7/site-packages/datasets/builder.py", line 650, in _download_and_prepare self._prepare_split(split_generator, **prepare_split_kwargs) File "/home/user/.pyenv/versions/3.7.9/lib/python3.7/site-packages/datasets/builder.py", line 1027, in _prepare_split for key, table in utils.tqdm(generator, unit=" tables", leave=False, disable=not_verbose): File "/home/user/.pyenv/versions/3.7.9/lib/python3.7/site-packages/tqdm/std.py", line 1133, in __iter__ for obj in iterable: File "/app/.cache/huggingface/modules/datasets_modules/datasets/json/9498524fd296a6cca99c66d6c5be507d1c0991f5a814e535b507f4a66096a641/json.py", line 83, in _generate_tables parse_options=self.config.pa_parse_options, File "pyarrow/_json.pyx", line 247, in pyarrow._json.read_json File "pyarrow/error.pxi", line 122, in pyarrow.lib.pyarrow_internal_check_status File "pyarrow/error.pxi", line 84, in pyarrow.lib.check_status pyarrow.lib.ArrowInvalid: straddling object straddles two block boundaries (try to increase block size?) ``` When using only a small portion of the sample file, say first 100 lines, it works perfectly well.. I see that it is the error from pyarrow, but could you give me a hint or possible solutions? #369 describes the same error and #372 claims to have fixed the issue, but I have no clue why I am still getting this one. Thanks in advance!
hwijeen
https://github.com/huggingface/datasets/issues/2181
null
false
852,258,635
2,180
Add tel to xtreme tatoeba
closed
[]
2021-04-07T10:23:15
2021-04-07T15:50:35
2021-04-07T15:50:34
This should fix issue #2149
lhoestq
https://github.com/huggingface/datasets/pull/2180
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2180", "html_url": "https://github.com/huggingface/datasets/pull/2180", "diff_url": "https://github.com/huggingface/datasets/pull/2180.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2180.patch", "merged_at": "2021-04-07T15:50:34" }
true
852,237,957
2,179
Load small datasets in-memory instead of using memory map
closed
[]
2021-04-07T09:58:16
2021-04-20T10:04:04
2021-04-20T10:04:03
Currently all datasets are loaded using memory mapping by default in `load_dataset`. However this might not be necessary for small datasets. If a dataset is small enough, then it can be loaded in-memory and: - its memory footprint would be small so it's ok - in-memory computations/queries would be faster - the caching on-disk would be disabled, making computations even faster (no I/O bound because of the disk) - but running the same computation a second time would recompute everything since there would be no cached results on-disk. But this is probably fine since computations would be fast anyway + users should be able to provide a cache filename if needed. Therefore, maybe the default behavior of `load_dataset` should be to load small datasets in-memory and big datasets using memory mapping.
lhoestq
https://github.com/huggingface/datasets/issues/2179
null
false
852,215,058
2,178
Fix cast memory usage by using map on subtables
closed
[]
2021-04-07T09:30:50
2021-04-20T14:20:44
2021-04-13T09:28:16
The `cast` operation on a pyarrow Table may create new arrays in memory. This is an issue since users expect memory mapped datasets to not fill up the RAM. To fix that I used `map` to write a new arrow file on disk when cast is used. To make things more convenient I introduced the `arrow` formatting of a dataset, to make it return pyarrow tables instead of python dicts. This way one can use pyarrow transforms directly when using `map`. edit: we'll use the same mechanism for `filter`
lhoestq
https://github.com/huggingface/datasets/pull/2178
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2178", "html_url": "https://github.com/huggingface/datasets/pull/2178", "diff_url": "https://github.com/huggingface/datasets/pull/2178.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2178.patch", "merged_at": "2021-04-13T09:28:16" }
true
852,065,307
2,177
add social thumbnial
closed
[]
2021-04-07T06:40:06
2021-04-07T08:16:01
2021-04-07T08:16:01
# What does this PR do? I added OpenGraph/ Twitter Card support to the docs to create nice social thumbnails. ![Bildschirmfoto 2021-04-07 um 08 36 50](https://user-images.githubusercontent.com/32632186/113821698-bac2ce80-977c-11eb-81aa-d8f16355857e.png) To be able to add these I needed to install `sphinxext-opengraph`. I came across this [issue](https://github.com/readthedocs/readthedocs.org/issues/1758) on the readthedocs repo saying that since someone has built this plugin they are not integrating and providing documentation to it. That's why I added it for creating the documentation. The repository can be found [here](https://github.com/wpilibsuite/sphinxext-opengraph/tree/main). P.S. It seemed that `make style` never ran for `docs/` i hope the changes are okay otherwise I'll revert it.
philschmid
https://github.com/huggingface/datasets/pull/2177
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2177", "html_url": "https://github.com/huggingface/datasets/pull/2177", "diff_url": "https://github.com/huggingface/datasets/pull/2177.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2177.patch", "merged_at": "2021-04-07T08:16:01" }
true
851,865,795
2,176
Converting a Value to a ClassLabel
closed
[]
2021-04-06T22:54:16
2022-06-01T16:31:49
2022-06-01T16:31:49
Hi! In the docs for `cast`, it's noted that `For non-trivial conversion, e.g. string <-> ClassLabel you should use map() to update the Dataset.` Would it be possible to have an example that demonstrates such a string <-> ClassLabel conversion using `map`? Thanks!
nelson-liu
https://github.com/huggingface/datasets/issues/2176
null
false
851,836,096
2,175
dataset.search_batch() function outputs all -1 indices sometime.
closed
[]
2021-04-06T21:50:49
2021-04-16T12:21:16
2021-04-16T12:21:15
I am working with RAG and playing around with different faiss indexes. At the moment I use **index = faiss.index_factory(768, "IVF65536_HNSW32,Flat")**. During the retrieval phase exactly in [this line of retrieval_rag.py](https://github.com/huggingface/transformers/blob/master/src/transformers/models/rag/retrieval_rag.py#L231) an error issue when all retrieved indices are -1. Please refer to the screenshot of a PID worker. ![image](https://user-images.githubusercontent.com/16892570/113782387-37a67600-9786-11eb-9c29-acad661a9648.png) Here, my retrieve batch size is 2 and n_docs is 5. I can solve this by working around np. stack, but I want to ask, why we get an output index of -1. Do you have any idea :) ? Is this a problem of the index, where the faiss can't find any similar vector? Is there documentation on the output index being -1? @lhoestq
shamanez
https://github.com/huggingface/datasets/issues/2175
null
false
851,383,675
2,174
Pin docutils for better doc
closed
[]
2021-04-06T12:40:20
2021-04-06T12:55:53
2021-04-06T12:55:53
The latest release of docutils make the navbar in the documentation weird and the Markdown wrongly interpreted: ![image](https://user-images.githubusercontent.com/35901082/113711773-5be55280-96b3-11eb-9b3b-9794f17709aa.png) We had the same problem in Transformers and solved it by pinning docutils (a dep of sphinx). You can see the version after the change [here](https://32769-250213286-gh.circle-artifacts.com/0/docs/_build/html/index.html).
sgugger
https://github.com/huggingface/datasets/pull/2174
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2174", "html_url": "https://github.com/huggingface/datasets/pull/2174", "diff_url": "https://github.com/huggingface/datasets/pull/2174.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2174.patch", "merged_at": "2021-04-06T12:55:53" }
true
851,359,284
2,173
Add OpenSLR dataset
closed
[]
2021-04-06T12:08:34
2021-04-12T16:54:46
2021-04-12T16:54:46
OpenSLR (https://openslr.org/) is a site devoted to hosting speech and language resources, such as training corpora for speech recognition, and software related to speech recognition. There are around 80 speech datasets listed in OpenSLR, currently this PR includes only 9 speech datasets SLR41, SLR42, SLR43, SLR44, SLR63, SLR64, SLR65, SLR66 and SLR69 (Javanese, Khmer, Nepali and Sundanese, Malayalam, Marathi, Tamil, Telugu and Catalan). I can add other speech datasets gradually next time.
cahya-wirawan
https://github.com/huggingface/datasets/pull/2173
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2173", "html_url": "https://github.com/huggingface/datasets/pull/2173", "diff_url": "https://github.com/huggingface/datasets/pull/2173.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2173.patch", "merged_at": "2021-04-12T16:54:45" }
true
851,229,399
2,172
Pin fsspec lower than 0.9.0
closed
[]
2021-04-06T09:19:09
2021-04-06T09:49:27
2021-04-06T09:49:26
Today's release of `fsspec` 0.9.0 implied a new release of `s3fs` 0.6.0 but this version breaks the CI (see [here](https://app.circleci.com/pipelines/github/huggingface/datasets/5312/workflows/490f3240-cd1c-4dd1-bb60-b416771c5584/jobs/32734) for example) I'm pinning `fsspec` until this has been resolved
lhoestq
https://github.com/huggingface/datasets/pull/2172
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2172", "html_url": "https://github.com/huggingface/datasets/pull/2172", "diff_url": "https://github.com/huggingface/datasets/pull/2172.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2172.patch", "merged_at": "2021-04-06T09:49:26" }
true
851,090,662
2,171
Fixed the link to wikiauto training data.
closed
[]
2021-04-06T07:13:11
2021-04-06T16:05:42
2021-04-06T16:05:09
mounicam
https://github.com/huggingface/datasets/pull/2171
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2171", "html_url": "https://github.com/huggingface/datasets/pull/2171", "diff_url": "https://github.com/huggingface/datasets/pull/2171.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2171.patch", "merged_at": "2021-04-06T16:05:09" }
true
850,913,228
2,170
Wikipedia historic dumps are deleted but hf/datasets hardcodes dump date
open
[]
2021-04-06T03:13:18
2021-06-16T01:10:50
null
Wikimedia does not keep all historical dumps. For example, as of today https://dumps.wikimedia.org/kowiki/ only provides ``` 20201220/ 02-Feb-2021 01:36 - 20210101/ 21-Feb-2021 01:26 - 20210120/ 02-Mar-2021 01:25 - 20210201/ 21-Mar-2021 01:26 - 20210220/ 02-Apr-2021 01:26 - 20210301/ 03-Mar-2021 08:10 - 20210320/ 21-Mar-2021 18:13 - 20210401/ 03-Apr-2021 10:08 - latest/ 03-Apr-2021 10:08 - ``` However, the wikipedia dataset provided in the library, only supports the following configs, none of which are applicable anymore when disregarding the cached datasets: ``` ValueError: BuilderConfig 20210401.ko not found. Available: ['20200501.aa', '20200501.ab', '20200501.ace', '20200501.ady', '20200501.af', '20200501.ak', '20200501.als', '20200501.am', '20200501.an', '20200501.ang', '20200501.ar', '20200501.arc', '20200501.arz', '20200501.as', '20200501.ast', '20200501.atj', '20200501.av', '20200501.ay', '20200501.az', '20200501.azb', '20200501.ba', '20200501.bar', '20200501.bat-smg', '20200501.bcl', '20200501.be', '20200501.be-x-old', '20200501.bg', '20200501.bh', '20200501.bi', '20200501.bjn', '20200501.bm', '20200501.bn', '20200501.bo', '20200501.bpy', '20200501.br', '20200501.bs', '20200501.bug', '20200501.bxr', '20200501.ca', '20200501.cbk-zam', '20200501.cdo', '20200501.ce', '20200501.ceb', '20200501.ch', '20200501.cho', '20200501.chr', '20200501.chy', '20200501.ckb', '20200501.co', '20200501.cr', '20200501.crh', '20200501.cs', '20200501.csb', '20200501.cu', '20200501.cv', '20200501.cy', '20200501.da', '20200501.de', '20200501.din', '20200501.diq', '20200501.dsb', '20200501.dty', '20200501.dv', '20200501.dz', '20200501.ee', '20200501.el', '20200501.eml', '20200501.en', '20200501.eo', '20200501.es', '20200501.et', '20200501.eu', '20200501.ext', '20200501.fa', '20200501.ff', '20200501.fi', '20200501.fiu-vro', '20200501.fj', '20200501.fo', '20200501.fr', '20200501.frp', '20200501.frr', '20200501.fur', '20200501.fy', '20200501.ga', '20200501.gag', '20200501.gan', '20200501.gd', '20200501.gl', '20200501.glk', '20200501.gn', '20200501.gom', '20200501.gor', '20200501.got', '20200501.gu', '20200501.gv', '20200501.ha', '20200501.hak', '20200501.haw', '20200501.he', '20200501.hi', '20200501.hif', '20200501.ho', '20200501.hr', '20200501.hsb', '20200501.ht', '20200501.hu', '20200501.hy', '20200501.ia', '20200501.id', '20200501.ie', '20200501.ig', '20200501.ii', '20200501.ik', '20200501.ilo', '20200501.inh', '20200501.io', '20200501.is', '20200501.it', '20200501.iu', '20200501.ja', '20200501.jam', '20200501.jbo', '20200501.jv', '20200501.ka', '20200501.kaa', '20200501.kab', '20200501.kbd', '20200501.kbp', '20200501.kg', '20200501.ki', '20200501.kj', '20200501.kk', '20200501.kl', '20200501.km', '20200501.kn', '20200501.ko', '20200501.koi', '20200501.krc', '20200501.ks', '20200501.ksh', '20200501.ku', '20200501.kv', '20200501.kw', '20200501.ky', '20200501.la', '20200501.lad', '20200501.lb', '20200501.lbe', '20200501.lez', '20200501.lfn', '20200501.lg', '20200501.li', '20200501.lij', '20200501.lmo', '20200501.ln', '20200501.lo', '20200501.lrc', '20200501.lt', '20200501.ltg', '20200501.lv', '20200501.mai', '20200501.map-bms', '20200501.mdf', '20200501.mg', '20200501.mh', '20200501.mhr', '20200501.mi', '20200501.min', '20200501.mk', '20200501.ml', '20200501.mn', '20200501.mr', '20200501.mrj', '20200501.ms', '20200501.mt', '20200501.mus', '20200501.mwl', '20200501.my', '20200501.myv', '20200501.mzn', '20200501.na', '20200501.nah', '20200501.nap', '20200501.nds', '20200501.nds-nl', '20200501.ne', '20200501.new', '20200501.ng', '20200501.nl', '20200501.nn', '20200501.no', '20200501.nov', '20200501.nrm', '20200501.nso', '20200501.nv', '20200501.ny', '20200501.oc', '20200501.olo', '20200501.om', '20200501.or', '20200501.os', '20200501.pa', '20200501.pag', '20200501.pam', '20200501.pap', '20200501.pcd', '20200501.pdc', '20200501.pfl', '20200501.pi', '20200501.pih', '20200501.pl', '20200501.pms', '20200501.pnb', '20200501.pnt', '20200501.ps', '20200501.pt', '20200501.qu', '20200501.rm', '20200501.rmy', '20200501.rn', '20200501.ro', '20200501.roa-rup', '20200501.roa-tara', '20200501.ru', '20200501.rue', '20200501.rw', '20200501.sa', '20200501.sah', '20200501.sat', '20200501.sc', '20200501.scn', '20200501.sco', '20200501.sd', '20200501.se', '20200501.sg', '20200501.sh', '20200501.si', '20200501.simple', '20200501.sk', '20200501.sl', '20200501.sm', '20200501.sn', '20200501.so', '20200501.sq', '20200501.sr', '20200501.srn', '20200501.ss', '20200501.st', '20200501.stq', '20200501.su', '20200501.sv', '20200501.sw', '20200501.szl', '20200501.ta', '20200501.tcy', '20200501.te', '20200501.tet', '20200501.tg', '20200501.th', '20200501.ti', '20200501.tk', '20200501.tl', '20200501.tn', '20200501.to', '20200501.tpi', '20200501.tr', '20200501.ts', '20200501.tt', '20200501.tum', '20200501.tw', '20200501.ty', '20200501.tyv', '20200501.udm', '20200501.ug', '20200501.uk', '20200501.ur', '20200501.uz', '20200501.ve', '20200501.vec', '20200501.vep', '20200501.vi', '20200501.vls', '20200501.vo', '20200501.wa', '20200501.war', '20200501.wo', '20200501.wuu', '20200501.xal', '20200501.xh', '20200501.xmf', '20200501.yi', '20200501.yo', '20200501.za', '20200501.zea', '20200501.zh', '20200501.zh-classical', '20200501.zh-min-nan', '20200501.zh-yue', '20200501.zu'] ``` The cached datasets: ``` % aws s3 --no-sign-request --endpoint-url https://storage.googleapis.com ls s3://huggingface-nlp/cache/datasets/wikipedia/ PRE 20200501.de/ PRE 20200501.en/ PRE 20200501.fr/ PRE 20200501.frr/ PRE 20200501.it/ PRE 20200501.simple/ ```
leezu
https://github.com/huggingface/datasets/issues/2170
null
false
850,456,180
2,169
Updated WER metric implementation to avoid memory issues
closed
[]
2021-04-05T15:43:20
2021-04-06T15:02:58
2021-04-06T15:02:58
This is in order to fix this issue: https://github.com/huggingface/datasets/issues/2078
diego-fustes
https://github.com/huggingface/datasets/pull/2169
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2169", "html_url": "https://github.com/huggingface/datasets/pull/2169", "diff_url": "https://github.com/huggingface/datasets/pull/2169.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2169.patch", "merged_at": null }
true
849,957,941
2,168
Preserve split type when realoding dataset
closed
[]
2021-04-04T20:46:21
2021-04-19T10:57:05
2021-04-19T09:08:55
Fixes #2167 Using `eval` is not ideal for security reasons (in web apps I assume), but without it the code would be much more complex IMO. In terms of style, instead of explicitly importing a private member (`_RelativeInstruction`), we can add these imports at the top of the module: ```python from . import arrow_reader # gives us access to ReadInstruction and _RelativeInstruction from . import splits # gives us access to NamedSplit ``` and then define the `eval` globals as follows: ```python {**arrow_reader.__dict__, **splits.__dict__} ```
mariosasko
https://github.com/huggingface/datasets/pull/2168
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2168", "html_url": "https://github.com/huggingface/datasets/pull/2168", "diff_url": "https://github.com/huggingface/datasets/pull/2168.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2168.patch", "merged_at": "2021-04-19T09:08:55" }
true
849,944,891
2,167
Split type not preserved when reloading the dataset
closed
[]
2021-04-04T19:29:54
2021-04-19T09:08:55
2021-04-19T09:08:55
A minimal reproducible example: ```python >>> from datasets import load_dataset, Dataset >>> dset = load_dataset("sst", split="train") >>> dset.save_to_disk("sst") >>> type(dset.split) <class 'datasets.splits.NamedSplit'> >>> dset = Dataset.load_from_disk("sst") >>> type(dset.split) # NamedSplit expected <class 'str'> ``` It seems like this bug was introduced in #2025.
mariosasko
https://github.com/huggingface/datasets/issues/2167
null
false
849,778,545
2,166
Regarding Test Sets for the GEM datasets
closed
[]
2021-04-04T02:02:45
2021-04-06T08:13:12
2021-04-06T08:13:12
@yjernite Hi, are the test sets for the GEM datasets scheduled to be [added soon](https://gem-benchmark.com/shared_task)? e.g. ``` from datasets import load_dataset DATASET_NAME="common_gen" data = load_dataset("gem", DATASET_NAME) ``` The test set doesn't have the target or references. ``` data['test'][0] {'concept_set_id': 0, 'concepts': ['drill', 'field', 'run', 'team'], 'gem_id': 'common_gen-test-0', 'gem_parent_id': 'common_gen-test-0', 'references': [], 'target': ''} ```
vyraun
https://github.com/huggingface/datasets/issues/2166
null
false
849,771,665
2,165
How to convert datasets.arrow_dataset.Dataset to torch.utils.data.Dataset
closed
[]
2021-04-04T01:01:48
2021-08-24T15:55:35
2021-04-07T15:06:04
Hi, I'm trying to pretraine deep-speed model using HF arxiv dataset like: ``` train_ds = nlp.load_dataset('scientific_papers', 'arxiv') train_ds.set_format( type="torch", columns=["input_ids", "attention_mask", "global_attention_mask", "labels"], ) engine, _, _, _ = deepspeed.initialize( args=args, model=model, model_parameters=[p for p in model.parameters() if p.requires_grad], training_data=train_ds) ``` but deepspeed.initialize accepts torch.utils.data.Dataset only. How can I convert HF-style dataset to torch-style dataset?
y-rokutan
https://github.com/huggingface/datasets/issues/2165
null
false
849,739,759
2,164
Replace assertTrue(isinstance with assertIsInstance in tests
closed
[]
2021-04-03T21:07:02
2021-04-06T14:41:09
2021-04-06T14:41:08
Replaces all the occurrences of the `assertTrue(isinstance(` pattern with `assertIsInstance`.
mariosasko
https://github.com/huggingface/datasets/pull/2164
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2164", "html_url": "https://github.com/huggingface/datasets/pull/2164", "diff_url": "https://github.com/huggingface/datasets/pull/2164.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2164.patch", "merged_at": "2021-04-06T14:41:08" }
true
849,669,366
2,163
Concat only unique fields in DatasetInfo.from_merge
closed
[]
2021-04-03T14:31:30
2021-04-06T14:40:00
2021-04-06T14:39:59
I thought someone from the community with less experience would be interested in fixing this issue, but that wasn't the case. Fixes #2103
mariosasko
https://github.com/huggingface/datasets/pull/2163
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2163", "html_url": "https://github.com/huggingface/datasets/pull/2163", "diff_url": "https://github.com/huggingface/datasets/pull/2163.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2163.patch", "merged_at": "2021-04-06T14:39:59" }
true
849,129,201
2,162
visualization for cc100 is broken
closed
[]
2021-04-02T10:11:13
2022-10-05T13:20:24
2022-10-05T13:20:24
Hi visualization through dataset viewer for cc100 is broken https://huggingface.co/datasets/viewer/ thanks a lot
dorost1234
https://github.com/huggingface/datasets/issues/2162
null
false
849,127,041
2,161
any possibility to download part of large datasets only?
closed
[]
2021-04-02T10:06:46
2022-10-05T13:26:51
2022-10-05T13:26:51
Hi Some of the datasets I need like cc100 are very large, and then I wonder if I can download first X samples of the shuffled/unshuffled data without going through first downloading the whole data then sampling? thanks
dorost1234
https://github.com/huggingface/datasets/issues/2161
null
false
849,052,921
2,160
data_args.preprocessing_num_workers almost freezes
closed
[]
2021-04-02T07:56:13
2021-04-02T10:14:32
2021-04-02T10:14:31
Hi @lhoestq I am running this code from huggingface transformers https://github.com/huggingface/transformers/blob/master/examples/language-modeling/run_mlm.py to speed up tokenization, since I am running on multiple datasets, I am using data_args.preprocessing_num_workers = 4 with opus100 corpus but this moves on till a point and then this freezes almost for sometime during tokenization steps and then this is back again, overall to me taking more time than normal case, I appreciate your advice on how I can use this option properly to speed up. thanks
dorost1234
https://github.com/huggingface/datasets/issues/2160
null
false
848,851,962
2,159
adding ccnet dataset
closed
[]
2021-04-01T23:28:36
2021-04-02T10:05:19
2021-04-02T10:05:19
## Adding a Dataset - **Name:** ccnet - **Description:** Common Crawl - **Paper:** https://arxiv.org/abs/1911.00359 - **Data:** https://github.com/facebookresearch/cc_net - **Motivation:** this is one of the most comprehensive clean monolingual datasets across a variety of languages. Quite important for cross-lingual reseach Instructions to add a new dataset can be found [here](https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md). thanks
dorost1234
https://github.com/huggingface/datasets/issues/2159
null
false
848,506,746
2,158
viewer "fake_news_english" error
closed
[]
2021-04-01T14:13:20
2022-10-05T13:22:02
2022-10-05T13:22:02
When I visit the [Huggingface - viewer](https://huggingface.co/datasets/viewer/) web site, under the dataset "fake_news_english" I've got this error: > ImportError: To be able to use this dataset, you need to install the following dependencies['openpyxl'] using 'pip install # noqa: requires this pandas optional dependency for reading xlsx files' for instance' as well as the error Traceback.
emanuelevivoli
https://github.com/huggingface/datasets/issues/2158
null
false
847,205,239
2,157
updated user permissions based on umask
closed
[]
2021-03-31T19:38:29
2021-04-06T07:19:19
2021-04-06T07:19:19
Updated user permissions based on running user's umask (#2065). Let me know if `0o666` is looking good or should I change it to `~umask` only (to give execute permissions as well)
bhavitvyamalik
https://github.com/huggingface/datasets/pull/2157
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2157", "html_url": "https://github.com/huggingface/datasets/pull/2157", "diff_url": "https://github.com/huggingface/datasets/pull/2157.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2157.patch", "merged_at": "2021-04-06T07:19:19" }
true
847,198,295
2,156
User permissions
closed
[]
2021-03-31T19:33:48
2021-03-31T19:34:24
2021-03-31T19:34:24
Updated user permissions based on running user's umask. Let me know if `0o666` is looking good or should I change it to `~umask` only (to give execute permissions as well)
bhavitvyamalik
https://github.com/huggingface/datasets/pull/2156
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2156", "html_url": "https://github.com/huggingface/datasets/pull/2156", "diff_url": "https://github.com/huggingface/datasets/pull/2156.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2156.patch", "merged_at": null }
true
846,786,897
2,155
Add table classes to the documentation
closed
[]
2021-03-31T14:36:10
2021-04-01T16:46:30
2021-03-31T15:42:08
Following #2025 , I added the table classes to the documentation cc @albertvillanova
lhoestq
https://github.com/huggingface/datasets/pull/2155
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2155", "html_url": "https://github.com/huggingface/datasets/pull/2155", "diff_url": "https://github.com/huggingface/datasets/pull/2155.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2155.patch", "merged_at": "2021-03-31T15:42:08" }
true
846,763,960
2,154
Adding the NorNE dataset for Norwegian POS and NER
closed
[]
2021-03-31T14:22:50
2021-04-01T09:27:00
2021-04-01T09:16:08
NorNE is a manually annotated corpus of named entities which extends the annotation of the existing Norwegian Dependency Treebank. Comprising both of the official standards of written Norwegian (Bokmål and Nynorsk), the corpus contains around 600,000 tokens and annotates a rich set of entity types including persons, organizations, locations, geo-political entities, products, and events, in addition to a class corresponding to nominals derived from names. See #1720.
versae
https://github.com/huggingface/datasets/pull/2154
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2154", "html_url": "https://github.com/huggingface/datasets/pull/2154", "diff_url": "https://github.com/huggingface/datasets/pull/2154.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2154.patch", "merged_at": "2021-04-01T09:16:08" }
true
846,181,502
2,153
load_dataset ignoring features
closed
[]
2021-03-31T08:30:09
2022-10-05T13:29:12
2022-10-05T13:29:12
First of all, I'm sorry if it is a repeated issue or the changes are already in master, I searched and I didn't find anything. I'm using datasets 1.5.0 ![image](https://user-images.githubusercontent.com/37592763/113114369-8f376580-920b-11eb-900d-94365b59f04b.png) As you can see, when I load the dataset, the ClassLabels are ignored, I have to cast the dataset in order to make it work. Code to reproduce: ```python import datasets data_location = "/data/prueba_multiclase" features = datasets.Features( {"texto": datasets.Value("string"), "label": datasets.features.ClassLabel(names=["false", "true"])} ) dataset = datasets.load_dataset( "csv", data_files=data_location, delimiter="\t", features=features ) ``` Dataset I used: [prueba_multiclase.zip](https://github.com/huggingface/datasets/files/6235022/prueba_multiclase.zip) (it has to be unzipped) Thank you! ❤️
GuillemGSubies
https://github.com/huggingface/datasets/issues/2153
null
false
845,751,273
2,152
Update README.md
closed
[]
2021-03-31T03:21:19
2021-04-01T10:20:37
2021-04-01T10:20:36
Updated some descriptions of Wino_Bias dataset.
JieyuZhao
https://github.com/huggingface/datasets/pull/2152
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2152", "html_url": "https://github.com/huggingface/datasets/pull/2152", "diff_url": "https://github.com/huggingface/datasets/pull/2152.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2152.patch", "merged_at": "2021-04-01T10:20:36" }
true
844,886,081
2,151
Add support for axis in concatenate datasets
closed
[]
2021-03-30T16:58:44
2021-06-23T17:41:02
2021-04-19T16:07:18
Add support for `axis` (0 or 1) in `concatenate_datasets`. Close #853.
albertvillanova
https://github.com/huggingface/datasets/pull/2151
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2151", "html_url": "https://github.com/huggingface/datasets/pull/2151", "diff_url": "https://github.com/huggingface/datasets/pull/2151.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2151.patch", "merged_at": "2021-04-19T16:07:18" }
true
844,776,448
2,150
Allow pickling of big in-memory tables
closed
[]
2021-03-30T15:51:56
2021-03-31T10:37:15
2021-03-31T10:37:14
This should fix issue #2134 Pickling is limited to <4GiB objects, it's not possible to pickle a big arrow table (for multiprocessing for example). For big tables, we have to write them on disk and only pickle the path to the table.
lhoestq
https://github.com/huggingface/datasets/pull/2150
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2150", "html_url": "https://github.com/huggingface/datasets/pull/2150", "diff_url": "https://github.com/huggingface/datasets/pull/2150.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2150.patch", "merged_at": "2021-03-31T10:37:14" }
true
844,734,076
2,149
Telugu subset missing for xtreme tatoeba dataset
closed
[]
2021-03-30T15:26:34
2022-10-05T13:28:30
2022-10-05T13:28:30
from nlp import load_dataset train_dataset = load_dataset('xtreme', 'tatoeba.tel')['validation'] ValueError: BuilderConfig tatoeba.tel not found. but language tel is actually included in xtreme: https://github.com/google-research/xtreme/blob/master/utils_preprocess.py def tatoeba_preprocess(args): lang3_dict = { 'afr':'af', 'ara':'ar', 'bul':'bg', 'ben':'bn', 'deu':'de', 'ell':'el', 'spa':'es', 'est':'et', 'eus':'eu', 'pes':'fa', 'fin':'fi', 'fra':'fr', 'heb':'he', 'hin':'hi', 'hun':'hu', 'ind':'id', 'ita':'it', 'jpn':'ja', 'jav':'jv', 'kat':'ka', 'kaz':'kk', 'kor':'ko', 'mal':'ml', 'mar':'mr', 'nld':'nl', 'por':'pt', 'rus':'ru', 'swh':'sw', 'tam':'ta', **_'tel':'te'_**, 'tha':'th', 'tgl':'tl', <----here 'tur':'tr', 'urd':'ur', 'vie':'vi', 'cmn':'zh', 'eng':'en', }
cosmeowpawlitan
https://github.com/huggingface/datasets/issues/2149
null
false
844,700,910
2,148
Add configurable options to `seqeval` metric
closed
[]
2021-03-30T15:04:06
2021-04-15T13:49:46
2021-04-15T13:49:46
Right now `load_metric("seqeval")` only works in the default mode of evaluation (equivalent to conll evaluation). However, seqeval library [supports](https://github.com/chakki-works/seqeval#support-features) different evaluation schemes (IOB1, IOB2, etc.), which can be plugged in just by supporting additional kwargs in `Seqeval._compute` https://github.com/huggingface/datasets/blob/85cf7ff920c90ca2e12bedca12b36d2a043c3da2/metrics/seqeval/seqeval.py#L109 Things that would be relevant are, for example, supporting `mode="strict", scheme=IOB2` to count only full entity match as a true positive and omit partial matches. The only problem I see is that the spirit of `metrics` seems to not require additional imports from user. `seqeval` only supports schemes as objects, without any string aliases. It can be solved naively with mapping like `{"IOB2": seqeval.scheme.IOB2}`. Or just left as is and require user to explicitly import scheme from `seqeval` if he wants to configure it past the default implementation. If that makes sense, I am happy to implement the change.
marrodion
https://github.com/huggingface/datasets/issues/2148
null
false
844,687,831
2,147
Render docstring return type as inline
closed
[]
2021-03-30T14:55:43
2021-03-31T13:11:05
2021-03-31T13:11:05
This documentation setting will avoid having the return type in a separate line under `Return type`. See e.g. current docs for `Dataset.to_csv`.
albertvillanova
https://github.com/huggingface/datasets/pull/2147
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2147", "html_url": "https://github.com/huggingface/datasets/pull/2147", "diff_url": "https://github.com/huggingface/datasets/pull/2147.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2147.patch", "merged_at": "2021-03-31T13:11:05" }
true
844,673,244
2,146
Dataset file size on disk is very large with 3D Array
open
[]
2021-03-30T14:46:09
2021-04-16T13:07:02
null
Hi, I have created my own dataset using the provided dataset loading script. It is an image dataset where images are stored as 3D Array with dtype=uint8. The actual size on disk is surprisingly large. It takes 520 MB. Here is some info from `dataset_info.json`. `{ "description": "", "citation": "", "homepage": "", "license": "", "features": { "image": { "shape": [224, 224, 3], "dtype": "uint8", "id": null, "_type": "Array3D", } }, "post_processed": null, "supervised_keys": null, "builder_name": "shot_type_image_dataset", "config_name": "default", "version": { "version_str": "0.0.0", "description": null, "major": 0, "minor": 0, "patch": 0, }, "splits": { "train": { "name": "train", "num_bytes": 520803408, "num_examples": 1479, "dataset_name": "shot_type_image_dataset", } }, "download_checksums": { "": { "num_bytes": 16940447118, "checksum": "5854035705efe08b0ed8f3cf3da7b4d29cba9055c2d2d702c79785350d72ee03", } }, "download_size": 16940447118, "post_processing_size": null, "dataset_size": 520803408, "size_in_bytes": 17461250526, }` I have created the same dataset with tensorflow_dataset and it takes only 125MB on disk. I am wondering, is it normal behavior ? I understand `Datasets` uses Arrow for serialization wheres tf uses TF Records. This might be a problem for large dataset. Thanks for your help.
jblemoine
https://github.com/huggingface/datasets/issues/2146
null
false